Skip to content

feat(notification): Use virtual txt file and telemetry url wrapper #5939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

feat(notification): Use virtual txt file and telemetry url wrapper #5939

merged 1 commit into from
Nov 6, 2024

Conversation

@tomcat323
Copy link
Contributor

@tomcat323 tomcat323 commented Nov 6, 2024

Created a ReadonlyDocument class in textDocumentUtilities to show a virtual read-only txt file. Converted existing txt notifications.

Use telemetry url wrapper instead of openExternal

Also updated some local notification JSON for future testing

@tomcat323 tomcat323 changed the title Feat(notification): Use virtual txt file and telemetry url wrapper feat(notification): Use virtual txt file and telemetry url wrapper Nov 6, 2024
@github-actions
Copy link

github-actions bot commented Nov 6, 2024

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@tomcat323 tomcat323 marked this pull request as ready for review November 6, 2024 21:25
@tomcat323 tomcat323 requested a review from a team as a code owner November 6, 2024 21:25
@aws aws deleted a comment from github-actions bot Nov 6, 2024
@tomcat323 tomcat323 merged commit 98d8324 into aws:master Nov 6, 2024
30 of 31 checks passed
@tomcat323 tomcat323 deleted the notification branch November 6, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@justinmk3 justinmk3 justinmk3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomcat323 @justinmk3